Skip to content

Add python linter to CI check#18

Merged
jparisu merged 3 commits intomainfrom
ci/python-lintern
Nov 21, 2022
Merged

Add python linter to CI check#18
jparisu merged 3 commits intomainfrom
ci/python-lintern

Conversation

@jparisu
Copy link
Copy Markdown
Contributor

@jparisu jparisu commented Nov 15, 2022

Signed-off-by: jparisu javierparis@eprosima.com

@jparisu jparisu temporarily deployed to codecov November 15, 2022 14:47 Inactive
@jparisu jparisu temporarily deployed to codecov November 15, 2022 14:47 Inactive
@jparisu jparisu temporarily deployed to codecov November 16, 2022 11:03 Inactive
@jparisu jparisu temporarily deployed to codecov November 16, 2022 11:03 Inactive
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 73.04% // Head: 72.64% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (2a93679) compared to base (96a49df).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   73.04%   72.64%   -0.41%     
==========================================
  Files          42       42              
  Lines         742      742              
  Branches      175      175              
==========================================
- Hits          542      539       -3     
- Misses        104      106       +2     
- Partials       96       97       +1     
Impacted Files Coverage Δ
..._utils/include/cpp_utils/wait/impl/WaitHandler.ipp 76.19% <0.00%> (-4.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu temporarily deployed to codecov November 16, 2022 14:22 Inactive
@jparisu jparisu temporarily deployed to codecov November 16, 2022 14:22 Inactive
@jparisu
Copy link
Copy Markdown
Contributor Author

jparisu commented Nov 16, 2022

In order to check the correct funcionality of this linter, previous commit 2a93679 has a tmp test file linter_test.tmp.py that tested the python linter with some errors that could be checked here: https://github.com/eProsima/dev-utils/actions/runs/3478742416/jobs/5816465789

irenebm
irenebm previously approved these changes Nov 16, 2022
@jparisu jparisu temporarily deployed to codecov November 21, 2022 06:55 Inactive
@jparisu jparisu temporarily deployed to codecov November 21, 2022 06:55 Inactive
@jparisu jparisu temporarily deployed to codecov November 21, 2022 07:02 Inactive
@jparisu jparisu temporarily deployed to codecov November 21, 2022 07:02 Inactive
jparisu added 3 commits November 21, 2022 10:02
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov November 21, 2022 09:02 Inactive
@jparisu jparisu temporarily deployed to codecov November 21, 2022 09:02 Inactive
@jparisu jparisu merged commit e913acb into main Nov 21, 2022
@jparisu jparisu deleted the ci/python-lintern branch November 21, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants